AcademySoftwareFoundation/openvdb

Redundant call to render function in vdb viewer

Open

#175 opened on Oct 2, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (762 forks)auto 404
good first issue

Repository metrics

Stars
 (3,343 stars)
PR merge metrics
 (PR metrics pending)

Description

https://github.com/dreamworksanimation/openvdb/blob/ffb02d5527379a08c07449e39d3324ac2e5eff28/openvdb/viewer/Viewer.cc#L1159

The mUpdates variable is reset at every key callback. However, I believe mUpdates should be reset only when key is pressed. Presently this variable is reset when the key is pressed as well as when it released. Due to this, the render function is called four times instead of two.

Contributor guide

Research direction
Inspect the key callback in Viewer.cc around line 1159. The mUpdates variable is reset on both key press and release events. It should only be reset on press. Modify the condition to reset mUpdates only when a key is pressed (i.e., when the event type is press). Then verify that the render function is called only twice per key interaction.
Tech stack
cpp
Domain
desktopcomputer graphics
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80