ApoorvSaxena/lozad.js

Elements aren't Unobserved if Loaded via triggerLoad

Open

#129 opened on Sep 11, 2018

View on GitHub
 (2 comments) (1 reaction) (0 assignees)JavaScript (476 forks)batch import
Hacktoberfestenhancement

Repository metrics

Stars
 (7,370 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I noticed that the triggerLoad function currently does not unobserve elements, so an unnecessary onIntersection can still happen that will return immediately due to the isLoaded check. I had the idea in my fork to instead of just adding observer.unobserve(element) in triggerLoad to also have the onIntersection and observe methods call triggerLoad instead of duplicating the code from triggerLoad. Would this be a sane change?

https://github.com/TiKevin83/lozad.js/commit/97e02bed37d0185eaccad9883a4d09c57f9f9604

Contributor guide

Research direction
Inspect the triggerLoad function and the onIntersection observer callback. Ensure triggerLoad calls observer.unobserve(element) to prevent unnecessary callbacks. Consider refactoring onIntersection and observe to call triggerLoad to avoid code duplication.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptIntersection Observer API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75