ArduPilot/ardupilot

nmea output code should use fixed buffer and fix snprintf issues

Open

#12,514 opened on Oct 8, 2019

View on GitHub
 (5 comments) (0 reactions) (0 assignees)C++ (15,603 forks)batch import
BUGLibrarygood first issue

Repository metrics

Stars
 (9,336 stars)
PR merge metrics
 (Avg merge 26d 16h) (166 merged PRs in 30d)

Description

The AP_NMEA_Output code should allocate buffers once for max size of strings, and also needs to fix the use of snprintf for the lng_string to ensure it doesn't end up with an unterminated string in %s for next printf

Contributor guide

Research direction
Identify the AP NMEA Output code location, understand the current buffer allocation and snprintf usage for lng string, then implement fixed size buffer and ensure snprintf properly terminates strings.
Tech stack
cpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65