ArduPilot/ardupilot

Plane: BUG with auto_state.checked_for_autoland

Open

#12,996 opened on Dec 6, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (15,603 forks)batch import
Planegood first issue

Repository metrics

Stars
 (9,336 stars)
PR merge metrics
 (Avg merge 26d 16h) (166 merged PRs in 30d)

Description

Bug report

Switch AUTO->RTL again an again, because checked_for_autoland always set to false when change mode

bool Mode::enter()
{
    // cancel inverted flight
    plane.auto_state.inverted_flight = false;

    // don't cross-track when starting a mission
    plane.auto_state.next_wp_crosstrack = false;

    // reset landing check
    plane.auto_state.checked_for_autoland = false;

Version 4.0 Platform [ ] All [ ] AntennaTracker [ ] Copter [*] Plane [ ] Rover [ ] Submarine

Airframe type What type of airframe (flying wing, glider, hex, Y6, octa etc)

Hardware type What autopilot hardware was used? (Pixhawk, Cube, Pixracer, Navio2, etc)

Logs Please provide a link to any relevant logs that show the issue

Contributor guide

Research direction
Identify the logic in Mode::enter() and ensure checked for autoland is not reset unnecessarily when switching modes. Consider adding a condition to preserve the flag when appropriate.
Tech stack
cpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75