ArduPilot/ardupilot

Plane: Landing permanently disable geofence

Open

#5,544 opened on Jan 11, 2017

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C++ (15,603 forks)batch import
BUGPlaneSafetygood first issue

Repository metrics

Stars
 (9,336 stars)
PR merge metrics
 (Avg merge 26d 16h) (166 merged PRs in 30d)

Description

Issue details

Once you begin a landing sequence the geofence can be disabled ( https://github.com/ArduPilot/ardupilot/blob/649ef0fc1614cacf823115cf8433319a4f8da563/ArduPlane/commands_logic.cpp#L404 ) but if you abort the landing or change modes for any reason the fence is never re enabled. (This is not related to AP_Landing changes, and is a pre existing bug)

Version

Master

Platform

[ ] All [ ] AntennaTracker [ ] Copter [ x ] Plane [ ] Rover

EDIT: Updated the link to the code to be useful/correct.

Contributor guide

Research direction
Examine the landing sequence code in commands logic.cpp to ensure the geofence is re enabled after a landing abort or mode change.
Tech stack
cpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75