Azure/data-api-builder

Sql: Refactor Mock tests to provide better additional mocks

Open

#353 opened on Apr 20, 2022

View on GitHub
 (2 comments) (0 reactions) (1 assignee)C# (348 forks)auto 404
good first issuemssql pgsql mysqlpgsqlrefactortesting

Repository metrics

Stars
 (1,459 stars)
PR merge metrics
 (PR metrics pending)

Description

In order to satisfy Mock test requirements, we had to add some default constructors/nullable properties. Mock tests should ideally be sending the required mocks so we don't have to keep nullable properties. This issue is to fix our tests to generate the right mocks.

Contributor guide

Research direction
Identify tests that rely on default constructors or nullable properties and refactor them to provide proper mocks. Examine existing mock setups to understand how to supply required mocks without workarounds.
Tech stack
csharp
Domain
backendtesting
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#unit testingmocking frameworks
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60