CleverRaven/Cataclysm-DDA

Exploit: You can reliably test water for parasites by checking the popup

Open

#54,097 opened on Jan 6, 2022

View on GitHub
 (8 comments) (0 reactions) (0 assignees)C++ (3,991 forks)batch import
<Bug><Exploit>Good First IssueItems: Food / Vitamins[C++]

Repository metrics

Stars
 (9,264 stars)
PR merge metrics
 (Avg merge 6d 5h) (292 merged PRs in 30d)

Description

Describe the bug

You can avoid parasites by just checking if the popup warns you about it. If there is no popup, you know you can drink your toilet water safely, with the risks just being food poisoning.

Steps to reproduce

See https://github.com/CleverRaven/Cataclysm-DDA/blob/7eac832b9241922dec92ad4dec9686ab6640061d/src/consumption.cpp#L825-L830

Expected behavior

If an item may have parasites, regardless of it actually having some, display the warning. This can get annoying if you are dehydrated and the toilet water is your only way, so there should be an option to hide that popup for say 50 turns.

This looks easy enough to do for any new C++ contributor since it is only a few lines of code.

Screenshots

No response

Versions and configuration

  • experimental

Additional context

No response

Contributor guide

Research direction
Examine the condition in src/consumption.cpp lines 825-830 that currently only warns when parasites are actually present, and modify it to always warn when water may contain parasites, then add a mechanism to suppress the warning for 50 turns.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85