CleverRaven/Cataclysm-DDA

Exploit: You can look at NPCs while blind

Open

#55,803 opened on Mar 3, 2022

View on GitHub
 (11 comments) (0 reactions) (0 assignees)C++ (3,991 forks)batch import
<Bug><Exploit>Good First IssueNPC / Factions[C++]

Repository metrics

Stars
 (9,264 stars)
PR merge metrics
 (Avg merge 6d 5h) (292 merged PRs in 30d)

Description

Describe the bug

See title.

Steps to reproduce

  1. Put on a blindfold or be blind in another way.
  2. Size up stats (only intelligence might make sense to be "visible" to you while blind) or look at the equipment of the NPC etc

Expected behavior

You get a message saying you can not see.

There should be a check in the code for blindness or high eye encumbrance (maybe, might be out of scope here) and alternative messages, e.g "You can't see what [NPC] is wearing!"

There should perhaps also be a check when you ask the NPC to teach you things. Teaching you social skills may work while blind, but this does not apply to combat or shooting or anything else, really.

Adding a check for blindness should be easy enough for new contributors. I considered adding Low Priority to this issue because this is not gamebreaking and more of an edge case.

Screenshots

No response

Versions and configuration

  • experimental

Additional context

No response

Contributor guide

Research direction
Look at the code for the 'size up' and 'examine' actions on NPCs. Add a check for player blindness (e.g., is blind) and return appropriate messages like 'You can't see what [NPC] is wearing' or 'You can't see [NPC]'s stats'. Also consider teaching actions.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80