CleverRaven/Cataclysm-DDA

Healing spell message can't be suppressed

Open

#61,977 opened on Oct 28, 2022

View on GitHub
 (3 comments) (1 reaction) (1 assignee)C++ (3,991 forks)batch import
(P3 - Medium)<Suggestion / Discussion>Good First IssueMechanics: Enchantments / Spells[C++]

Repository metrics

Stars
 (9,264 stars)
PR merge metrics
 (Avg merge 6d 5h) (292 merged PRs in 30d)

Description

Describe the bug

As the title says, the message %s wounds are closing up! can't be suppressed in any way, which make stuff sometimes a bit tricky. Not a big deal, but i don't like it

Steps to reproduce

Just cast a healing spell, and see you can't supress it (default "message": "" do nothing)

Expected behavior

Being able to supress the message

Screenshots

Pretty odd to see "you heal X" from the creature, that you sacrifice to heal yourself

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19044.2130 (21H2)
  • Game Version: a338bfd [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], No Fungal Growth [no_fungal_growth], Bionic Professions [package_bionic_professions], Magiclysm [magiclysm], Xedra Evolved [xedra_evolved], Mythical Martial Arts [MMA] ]

Additional context

There will be some pr, bonded to this issue, but im working on it now

Ping @Venera3 as a potential saviour :derpy:

Contributor guide

Research direction
Find where the healing spell message '%s wounds are closing up!' is printed and add a check to suppress it when message suppression is enabled.
Tech stack
cpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75