CleverRaven/Cataclysm-DDA

Charge removal side effects 1: tiny items

Open

#67,324 opened on Jul 31, 2023

View on GitHub
 (0 comments) (2 reactions) (0 assignees)C++ (3,991 forks)batch import
(S2 - Confirmed)Help WantedItems / Item Actions / Item Qualities

Repository metrics

Stars
 (9,264 stars)
PR merge metrics
 (Avg merge 6d 5h) (292 merged PRs in 30d)

Description

Describe the bug

A few items had really tiny charges smaller than 1ml. Because we have no unit smaller than that, all of them were rounded up to 1ml and most likely could use an audit to check their stats.

The list of affected items can be found here: https://gist.github.com/mqrause/dc234737bfd5c4309aa4dc496d17bd53#file-oversized_charge_removal-txt

Attach save file

n/a

Steps to reproduce

n/a

Expected behavior

n/a

Screenshots

No response

Versions and configuration

6088293934801590f503ff9d5d961e708af564ff

Additional context

No response

Contributor guide

Research direction
Examine the rounding logic for item charges and audit the items in the provided gist to correct their stats.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65