CleverRaven/Cataclysm-DDA

Refugee center guards use spears instead of guns, despite having them for sale?

Open

#70,986 opened on Jan 16, 2024

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (3,991 forks)batch import
Help WantedItems / Item Actions / Item QualitiesNPC / Factions[JSON]

Repository metrics

Stars
 (9,264 stars)
PR merge metrics
 (Avg merge 6d 5h) (292 merged PRs in 30d)

Description

Describe the bug

In previous versions of the game, the refugee guards all wielded firearms. Now, they're all wielding some spear(-Old Guard rep, the arsonist, and the hireable merc). Smokes still sells guns & ammo.

Attach save file

N/A

Steps to reproduce

  1. Go to refugee center.
  2. See guards wield variants of spears.
  3. Talk to Smokes, see he still sells civilian guns & ammo.

Expected behavior

In-universe acknowledgement of why the guards use spears, Smokes doesn't sell guns, or they have guns again.

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.22631.3007 (23H2)
  • Game Version: df65266 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Portal Storms Ignore NPCs [personal_portal_storms], Slowdown Fungal Growth [no_fungal_growth], No Rail Stations [No_Rail_Stations] ]

Additional context

No response

Contributor guide

Research direction
Investigate the NPC class definitions for refugee guards in the game code, focusing on their default weapon loadout. Look for recent commits that may have changed the guard equipment from guns to spears.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65