DioxusLabs/taffy

Support `Display::FlowRoot`

Open

#484 opened on May 18, 2023

View on GitHub
 (2 comments) (0 reactions) (1 assignee)Rust (192 forks)github user discovery
good first issue

Repository metrics

Stars
 (3,189 stars)
PR merge metrics
 (PR metrics pending)

Description

What problem does this solve or what need does it fill?

display: flow-root nodes use the same algorithm as CSS Block layout, except that they force the creation of a new https://developer.mozilla.org/en-US/docs/Web/Guide/CSS/Block_formatting_context. In practice the main impact of this will be to prevent margin collapsing between the Display::FlowRoot node and it's children, or through the Display::FlowRoot node. If in future we support floats, it would also affect those.

What solution would you like?

Implement support for Display::FlowRoot in Taffy, by adding a new variant to the Display enum and updating the Block Layout implementation to work with it.

Contributor guide

Research direction
Add a new 'FlowRoot' variant to the 'Display' enum and update the Block Layout implementation to treat it as Block layout but with a new block formatting context, preventing margin collapsing.
Tech stack
rust
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65