FAForever/server

Maximum precision for float serialization

Open

#875 opened on Jan 1, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (79 forks)auto 404
good first issue

Repository metrics

Stars
 (72 stars)
PR merge metrics
 (PR metrics pending)

Description

We should explicitly set the number of decimal places to use for float serialization. This will probably have to be done by subclassing the default JSONEncoder and using a custom float wrapper that knows how to serialize itself with a certain precision. It might also be possible using the standard library Decimal type. We should make sure to consider the impact on the performance of serialization.

https://docs.python.org/3.9/library/json.html#json.JSONEncoder

Fields affected:

  • queue_pop_time_delta in matchmaker_info

Contributor guide

Research direction
Explore subclassing JSONEncoder with a custom float wrapper or using Decimal type for precision control, and measure the performance impact on serialization.
Tech stack
python
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55