Flipboard/bottomsheet

Add option to keep state between sheet displays

Open

#92 opened on Dec 2, 2015

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Java (609 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (4,540 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Due to the asynchronous handling when dismissing/showing the view it is impossible to have listeners set after re-showing.

First time:

  • add state change listener
  • show view -> listener gets called

Second time:

  • add listener
  • show view (it is already showing) -> calls dismiss and returns
  • gets dismissed -> removes all listeners (including new ones)
  • runnable shows view again -> no listeners

Adding the listeners after calling show also doesn't work (because the runnable to show again is asynchronously called from the dismiss animation callback)

My idea would be to store a local copy of the listeners in the dismiss method and clean the global fields. Then from the animation listener:

  • When it wasn't cancelled call the local listeners.
  • If it was cancelled put the local listeners back into the global fields. (To remain the state before the dismiss)

Contributor guide

Research direction
Investigate the dismiss and show logic in the bottom sheet. Trace the listener management in the dismiss animation callback. Consider storing a local copy of listeners before dismiss and restoring them if cancelled.
Tech stack
javaandroid
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Android development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50