GoogleChromeLabs/jsvu

Incorrect path being made in .cmd wrapper on windows.

Open

#68 opened on Apr 12, 2019

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (96 forks)github user discovery
enhancementgood first issue

Repository metrics

Stars
 (2,024 stars)
PR merge metrics
 (PR metrics pending)

Description

Following the execution path:

https://github.com/GoogleChromeLabs/jsvu/blob/853836d94d207f6c8f487f272121b0bd4a5f7b72/shared/installer.js#L46 https://github.com/GoogleChromeLabs/jsvu/blob/853836d94d207f6c8f487f272121b0bd4a5f7b72/shared/installer.js#L131-L132 https://github.com/GoogleChromeLabs/jsvu/blob/853836d94d207f6c8f487f272121b0bd4a5f7b72/shared/installer.js#L134

Which results in this:

@echo off
"%~dp0engines/v8\v8.exe" --natives_blob="%~dp0engines/v8\natives_blob.bin" --snapshot_blob="%~dp0engines/v8\snapshot_blob.bin" %*

Contributor guide

Research direction
Examine the path construction in installer.js lines 46, 131-132, 134 to understand where the mixed slash issue occurs. Test the .cmd wrapper on Windows and propose a fix to normalize path separators.
Tech stack
javascriptnodejs
Domain
backendtooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.jsWindows
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70