GoogleCloudPlatform/cloud-data-quality

add more default rule types

Open

#2 opened on Apr 3, 2021

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Python (58 forks)auto 404
good first issuehelp wanted

Repository metrics

Stars
 (280 stars)
PR merge metrics
 (PR metrics pending)

Description

We should be able to implement all of dbt's schema tests as CUSTOM_SQL_STATEMENT. There may be other rules we can implement from https://docs.greatexpectations.io/en/latest/reference/glossary_of_expectations.html#dataset.

We should consider how to allow rules that reference multiple tables using references to tables (with overrides). The current alternative is to parameterize the table names.

It it make sense we may want to implement the rule directly in https://github.com/GoogleCloudPlatform/cloud-data-quality/blob/main/clouddq/classes/rule_type.py

Contributor guide

Research direction
Review the dbt schema tests and Great Expectations expectations listed in the issue. Understand how CUSTOM SQL STATEMENT rules are defined in clouddq/classes/rule type.py. Identify which tests can be implemented as single table rules and which require multi table references. Consider parameterization for table names.
Tech stack
pythonsql
Domain
databackend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitPythonSQL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60