GoogleContainerTools/skaffold

Load images into minikube rather than replacing host's docker env

Open

#4,654 opened on Aug 12, 2020

View on GitHub
 (2 comments) (1 reaction) (0 assignees)Go (1,416 forks)batch import
area/buildhelp wantedkind/feature-requestplatform/minikubepriority/p2

Repository metrics

Stars
 (12,822 stars)
PR merge metrics
 (Avg merge 3d 6h) (16 merged PRs in 30d)

Description

currently in skaffold, if we detect a user has minikube as their active kubecontext, we run a minikube docker-env so that docker commands on the host machine build to minikube's docker daemon. this can cause issues if we're only trying to run a skaffold build while minikube is stopped - something that should be possible, but skaffold can't get around because it only knows to try and use minikube's docker daemon.

instead, we could use minikube cache add on images that are built locally, and do this on push, so builds will still work even when minikube's docker daemon is not accessible.

https://minikube.sigs.k8s.io/docs/handbook/pushing

Contributor guide

Research direction
Investigate how to use `minikube cache add` to push locally built images to minikube's cache instead of swapping the Docker environment. Modify the Skaffold build pipeline to call `minikube cache add` after building images, ensuring images are available even when minikube's Docker daemon is not running.
Tech stack
godockerkubernetes
Domain
infrastructuredevopscli
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoDockerKubernetesMinikube
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50