GoogleContainerTools/skaffold

Dockerfile file analysis should support Buildkit's `RUN --mount`

Open

#6,091 opened on Jun 28, 2021

View on GitHub
 (1 comment) (3 reactions) (0 assignees)Go (1,416 forks)batch import
area/buildbuild/dockerhelp wantedkind/feature-requestpriority/p2

Repository metrics

Stars
 (12,822 stars)
PR merge metrics
 (Avg merge 3d 6h) (16 merged PRs in 30d)

Description

(From the #skaffold Slack channel)

Buildkit supports run --mount=type=bind,source=xxx,target=yyy which behaves similar to a COPY xxx yyy. The type=bind can be omitted as this is the default mount type.

The doc does say that this is only valid with dockerfile syntax 1.2 or above:

To use this flag set Dockerfile version to at least 1.2

# syntax=docker/dockerfile:1.2

Expected behavior

Skaffold would detect changes to the source in xxx and trigger a rebuild.

Actual behavior

Skaffold doesn't detect the source changes.

Information

  • Skaffold version: unspecified

Workaround

Insert manual COPY statements.

Contributor guide

Research direction
Investigate how Skaffold's Dockerfile dependency parser works and extend it to recognize `RUN mount=type=bind,source=xxx,target=yyy` as a file dependency.
Tech stack
go
Domain
backenddevopsbuild system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
DockerGoSkaffold
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70