GoogleContainerTools/skaffold

Helm 2 rebuild on requirements.lock change

Open

#6,943 opened on Dec 6, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Go (1,416 forks)batch import
area/deploydeploy/helmhelp wantedkind/feature-requestpriority/p2

Repository metrics

Stars
 (12,822 stars)
PR merge metrics
 (Avg merge 3d 6h) (16 merged PRs in 30d)

Description

On Skaffold v1.35.0, when a Helm 2 deploy is used, as soon as the dependency's requirements.lock file is added or changes, a rebuild is launched. Seems like #4181 was aimed at fixing this but somehow this only prevents the rebuild for the tmpcharts folder and its content, not the requirements.lock file.

Expected behavior

No rebuild on requirements.lock change

Actual behavior

Rebuild on requirements.lock change

Information

deploy:
  helm:
    releases:
    - name: project
      chartPath: helm
      artifactOverrides:
        backendImage: backend-image
        frontendImage: frontend-image
        databaseImage: database-image
      valuesFiles:
      - helm/values.yaml
      - helm/values.yaml.override
    flags:
      upgrade:
        - '--cleanup-on-fail'

Steps to reproduce the behavior

Use a Helm 2 chart having a dependency, on first install the project builds twice because of the creation of the requirements.lock file

Contributor guide

Research direction
Inspect the file watcher configuration and the change detection logic that triggers rebuilds. Ensure that requirements.lock is added to the ignore list, similar to tmpcharts folder as done in #4181.
Tech stack
go
Domain
backenddevopsbuild system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitGo
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65