GreptimeTeam/greptimedb-ingester-go

support different struct in WriteObject

Open

#25 opened on Feb 27, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Go (7 forks)auto 404
good first issue

Repository metrics

Stars
 (16 stars)
PR merge metrics
 (PR metrics pending)

Description

for now, ingester-go only support one type in Client.WriteObject, but it should behave like ingester-java, like:

resp, err := client.WriteObject(context.Background(), cup1, mem1, cup2, mem2)

Function signature

from

func (c *Client) WriteObject(ctx context.Context, obj any) (*gpb.GreptimeResponse, error)

to

func (c *Client) WriteObject(ctx context.Context, objs ...any) (*gpb.GreptimeResponse, error)

NOTE

  • To simplify the maintenance, WriteObject use variadic parameters

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.