IBM/tekton-lint

Report missing parameter in TaskSpec (inline tasks)

Open

#61 opened on Nov 26, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (21 forks)auto 404
good first issuehacktoberfesthelp wanted

Repository metrics

Stars
 (32 stars)
PR merge metrics
 (PR metrics pending)

Description

In 0.5.2 we should report missing parameters in taskSpec tasks

Example:


    - name: inline-task
      params:
        - name: pipeline-debug
          value: $(params.pipeline-debug)
      workspaces:
        - name: secrets
          workspace: artifacts
      taskSpec:
        workspaces:
          - name: secrets
            mountPath: /secrets
        params:
          - name: pipeline-debug
        stepTemplate:
          env:
            - name: PIPELINE_RUN_ID
              valueFrom:
                fieldRef:
                  fieldPath: metadata.annotations['devops.cloud.ibm.com/tekton-pipeline']
        steps:
          - name: setup
            image: node:alpine
            script: |
              #!/bin/bash

              set -e -o pipefail

              if [ $PIPELINE_DEBUG == 1 ]; then
                pwd
                env
                trap env EXIT
                set -x
              fi

              export TOKEN=$(cat "/secrets/$(params.token)")

The line export TOKEN=$(cat "/secrets/$(params.token)") use a parameter token which was not added nor provided for the task, the linter is missing this.

Contributor guide