JanusGraph/janusgraph

hasId does not convert int to Long

Open

#1,554 opened on May 6, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Java (1,137 forks)batch import
area/corehelp wantedkind/enhancement

Repository metrics

Stars
 (4,985 stars)
PR merge metrics
 (Avg merge 3d 18h) (12 merged PRs in 30d)

Description

If an int is passed instead of a String or a Long to hasId() it does not get converted and results won't be yielded. This behavior has been report in issue #706, but I think this would be a nice improvement.

I think looking at the HasStepFolder.foldInIds() method might be a good place to start.

Additional info can be found in this stack overflow question and this tinkerpop issue

Contributor guide

Research direction
Inspect the foldInIds method in HasStepFolder.java and trace how hasId handles numeric types from the TinkerPop adapter.
Tech stack
java
Domain
backenddatabase
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJava
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60