JuliaDynamics/DrWatson.jl

Savename expand for nested structs is not working

Open

#215 opened on Nov 19, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Julia (94 forks)batch import
buggood first issuesavename

Repository metrics

Stars
 (915 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

As savename works for structs, I think it should also be possible to expand them. This doesn't work at the moment because of https://github.com/JuliaDynamics/DrWatson.jl/blob/1eece239953ab2a5aa6de1c9cb67236df0665264/src/naming.jl#L119 which, unless defined for the struct, throws an error for non-iterable types.

Contributor guide

Research direction
Inspect the behavior of `savename` with nested structs and trace the error to line 119 in `src/naming.jl`. Implement a fix that allows expansion of non iterable structs.
Tech stack
julia
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JuliaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75