JuliaGeometry/Meshes.jl

Visualization of `Line`

Open

#534 opened on May 21, 2023

View on GitHub
 (5 comments) (1 reaction) (0 assignees)Julia (98 forks)auto 404
featurehelp wantedviz

Repository metrics

Stars
 (460 stars)
PR merge metrics
 (PR metrics pending)

Description

Small bug : seems the infinite long line is not possible to discretize ?

using Meshes, MeshViz
using CairoMakie: activate!; activate!()
ln = Line(Point(1,1,1), Point(0,0,0))
viz(ln)

yields StackOverflowError

Stacktrace: [1] simplexify(geometry::Line{3, Float64}) @ Meshes ~/.julia/packages/Meshes/1Iszy/src/discretization.jl:135 [2] discretize(geometry::Line{3, Float64}) @ Meshes ~/.julia/packages/Meshes/1Iszy/src/discretization.jl:103 --- the last 2 lines are repeated 39990 more times --- [79983] simplexify(geometry::Line{3, Float64}) @ Meshes ~/.julia/packages/Meshes/1Iszy/src/discretization.jl:135

Got the same with GLMakie backend.

Contributor guide

Research direction
Inspect the discretization logic for Line geometries. The simplexify function is recursively calling discretize without a base case for Line. Check if a specific method for Line is missing or if the generic method needs adjustment.
Tech stack
julia
Domain
computer graphics
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JuliaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75