JuliaLang/julia

re-evaluate/remove `Random.UnsafeView`

Open

#36,718 opened on Jul 17, 2020

View on GitHub
 (7 comments) (3 reactions) (0 assignees)Julia (5,773 forks)batch import
good first issuehelp wantedrandomnessstdlib

Repository metrics

Stars
 (48,709 stars)
PR merge metrics
 (Avg merge 20d 6h) (157 merged PRs in 30d)

Description

I just noticed the Random stdlib has an UnsafeView type for filling arrays. With the new layout optimizations, this should no longer be necessary. We should try using the normal SubArray type for this. If it's still too slow/complex, then at least the type can be made safe by holding the underlying array directly instead of a Ptr.

Contributor guide

Research direction
Examine the implementation of Random.UnsafeView and its usage in the standard library. Attempt to replace it with SubArray and test performance. If unsuccessful, modify UnsafeView to hold the underlying array directly instead of a Ptr.
Tech stack
None
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JuliaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35