JuliaLang/julia

Replace uses of tempname in CI by mktemp

Open

#43,597 opened on Dec 29, 2021

View on GitHub
 (10 comments) (0 reactions) (0 assignees)Julia (5,773 forks)batch import
cigood first issuehelp wanted

Repository metrics

Stars
 (48,709 stars)
PR merge metrics
 (Avg merge 20d 6h) (157 merged PRs in 30d)

Description

As of #38879 our temp path generation depends on the global RNG. That's probably not a bad idea in general, except that various parts of the test suite seed the global RNG, so this will cause reliable collisions in the test suite, so we'll get in trouble with tests stomping on each other. We should audit all uses of tempname in the test suite and replace them with mktemp unless they test the tempname function specifically.

Contributor guide

Research direction
Find all uses of `tempname` in the test suite and replace them with `mktemp` (or `tempname` with explicit seed) to avoid collisions from seeded RNG, except where testing `tempname` itself.
Tech stack
julia
Domain
testing
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JuliaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70