Kareadita/Kavita

Missing image that occurs when a non-English or numeric file name exists in a compressed file

Open

#2,234 opened on Aug 24, 2023

View on GitHub
 (7 comments) (0 reactions) (0 assignees)C# (598 forks)batch import
bughelp wanted

Repository metrics

Stars
 (10,538 stars)
PR merge metrics
 (Avg merge 16d 13h) (12 merged PRs in 30d)

Description

test2.zip The uploaded file is a test compression file. You can reproduce the same phenomenon with these files. If you go to the actual cache folder, you can see that two image files are missing. There seems to be a person who has similar symptoms on the discord channel. Originally, it was right to attach a log, but I couldn't upload it because there was no record in the log.

Tested at version 0.7.7 and docker environment. Host os is ubuntu 22.04 The client environment is windows 11 22H2 I tested with the latest version of Chrome and Edge.

Contributor guide

Research direction
Trace the code responsible for extracting zip files and handling file names with non ASCII characters. Check if there is an encoding issue or path sanitization missing.
Tech stack
csharp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60