Lightning-AI/lightning-thunder

How do I access the `ThunderModule` if I'm compiling a function?

Open

#121 opened on Apr 2, 2024

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (114 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (1,460 stars)
PR merge metrics
 (PR metrics pending)

Description

🚀 Feature

Motivation

Sometimes the code requires that a ThunderModule is passed, however, if the user is compiling a function that takes the module as an argument, the user doesn't have a way to get a reference to it.

For example, #96 implements a workaround for this issue with the no_sync context manager.

Pitch

Provide an API to get this reference. Maybe it's something like thunder.compile_data(jitted_function).module.

Additional context

The design might need to consider the presence of multiple ThunderModules.

Contributor guide

Research direction
Explore the existing compilation API to find where ThunderModule is created and how to expose it. Consider adding a method like `thunder.compile data(jitted function).module` and handle multiple modules.
Tech stack
pythonpytorch
Domain
compilersdeveloper experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonPyTorch
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75