MSRevive/MasterSwordRebirth

Refactor the use of macros in via code

Open

#123 opened on Nov 30, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (16 forks)auto 404
enhancement 🔧good first issuemed priority

Repository metrics

Stars
 (20 stars)
PR merge metrics
 (PR metrics pending)

Description

I think it would be better if we got rid of the use of macros throughout the code, which would help clean up some of the code.

Contributor guide

Research direction
Locate all macro definitions and usages in the source files, evaluate if they can be replaced with constexpr or inline functions, and update them accordingly.
Tech stack
cpp
Domain
game dev
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70