ManageIQ/miq_bot

New OffenseMessage builder does not sort locators properly.

Open

#202 opened on Jul 1, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Ruby (38 forks)auto 404
bughelp wantedpinned

Repository metrics

Stars
 (16 stars)
PR merge metrics
 (PR metrics pending)

Description

Since it does string sort, Line 103 comes before Line 5. We probably need to change locator from being string based to being numeric, or specific on line vs commit_sha or something. @bdunne

Contributor guide

Research direction
Investigate how locators are represented in OffenseMessage and change sorting from string comparison to numeric comparison for line numbers.
Tech stack
ruby
Domain
toolingdeveloper experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitRuby
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70