ManageIQ/miq_bot

regex in notification monitor for WIP is insufficient

Open

#334 opened on Mar 28, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Ruby (38 forks)auto 404
buggood first issuehelp wantedpinned

Repository metrics

Stars
 (16 stars)
PR merge metrics
 (PR metrics pending)

Description

https://github.com/ManageIQ/miq_bot/blob/96d28fab4f605844b02b50911cba2adc114d49f6/lib/github_service/issue.rb#L7 is insufficient as it only looks for WIP at the start. This can be better handled by reusing the pr_title_tags method: https://github.com/ManageIQ/miq_bot/blob/e81985b7bef0227b963a8372a444178a56a462fe/app/models/branch.rb#L65-L67 , which is what's used by the wip_labeler worker.

See ManageIQ/manageiq#14551 for an example of where it double-wipped a PR.

Contributor guide

Research direction
Examine the regex in lib/github service/issue.rb line 7 and replace it with the logic from app/models/branch.rb lines 65-67 (the pr title tags method). Ensure that the wip labeler worker's approach is reused consistently.
Tech stack
ruby
Domain
backendtooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60