MetOffice/CSET

Make constraints tests more robust

Open

#838 opened on Sep 17, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (16 forks)auto 404
cleanupgood first issue

Repository metrics

Stars
 (28 stars)
PR merge metrics
 (PR metrics pending)

Description

I don't think checking the result of repr is sufficient for many of the tests in this file. In particular those where the repr just says a lambda or function. The relevant lambda or function could be changed to something that produces complete nonsense and these tests would never catch it. It's not really related to this PR though so I'd suggest opening a new issue.

Originally posted by @SGallagherMet in https://github.com/MetOffice/CSET/pull/765#discussion_r1740967262

We should make the tests in test_constraints.py more robust. This will likely involve making most of them into filter tests.

Contributor guide

Research direction
Examine the constraints tests in test constraints.py and convert them to filter tests to ensure robustness. Validate that the tests actually verify the constraint logic.
Tech stack
python
Domain
testing
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70