Microsoft/calculator

Centralize BiDirectional string code in the CalcViewModel

Open

#65 opened on Feb 27, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (2,422 forks)batch import
Pri: 2approvedcodebase qualityhelp wanted

Repository metrics

Stars
 (16,196 stars)
PR merge metrics
 (Avg merge 15h 43m) (7 merged PRs in 30d)

Description

BiDi code is spread out - Memory panel sets BiDi in the view model, while History sets it in the CalcManager. The UnitTests also do their own thing. We should centralize the code into utility functions in the VM and then have unit tests for their functionality.

Contributor guide

Research direction
Examine the codebase for existing BiDi logic in Memory panel view model and History panel CalcManager, then create centralized utility functions in CalcViewModel and write unit tests.
Tech stack
cpp
Domain
desktop
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60