Neptune-Crypto/neptune-core

When sync mode is exited, request a block notification from peers

Open

#37 opened on Aug 12, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Rust (45 forks)auto 404
good first issuenetworking

Repository metrics

Stars
 (110 stars)
PR merge metrics
 (PR metrics pending)

Description

When syncing mode is exited, the client might still be missing some blocks as syncing mode is only used when the client is ~50 to ~100 blocks behind a peer, where the precise number is determined by max_number_of_blocks_before_syncing value which can be set from the CLI and defaults to 100.

Therefore, a client should send a BlockNotificationRequest to some of its peers after syncing mode is abandoned, to catch up with the few remaining blocks.

The relevant place that mutates the syncing value is in the handle_peer_thread_message method in main_loop.rs

Contributor guide

Research direction
Examine the handle peer thread message method in main loop.rs to understand how syncing mode is exited, then implement a BlockNotificationRequest to peers upon exit.
Tech stack
rust
Domain
backendnetworkingblockchain
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RustGitP2P networking basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60