NuGet/Home

nuget.exe pack with both -symbols and -suffix give incorrect name to symbol package

Open

#3,530 opened on Sep 26, 2016

View on GitHub
 (6 comments) (2 reactions) (0 assignees)HTML (292 forks)batch import
Functionality:PackPriority:2Type:Bughelp wanted

Repository metrics

Stars
 (1,459 stars)
PR merge metrics
 (Avg merge 464d 23h) (1 merged PR in 30d)

Description

Steps

  1. Create a .nuspec on disk.
  2. Make sure there are some files to pack (nuget.exe pack won't make an empty package).
  3. Run nuget.exe pack path\to\my.nuspec -symbols -suffix beta

Expected

Two nupkgs, one ending in beta.nupkg and the other ending in beta.symbols.nupkg.

Actual

The symbols package's file name has the version number without the suffix. The .nuspec inside the package seems fine though.

Example

nuget.exe pack VS.Redist.NuGet_VS15.nuspec -symbols -suffix BETA

Attempting to build package from 'VS.Redist.NuGet_VS15.nuspec'.
Successfully created package 'C:\Users\jver\Desktop\foo\VS.Redist.NuGet_VS15.3.5.160923.1438-BETA.nupkg'.
Successfully created package 'C:\Users\jver\Desktop\foo\VS.Redist.NuGet_VS15.3.5.160923.1438-bar.symbols.nupkg'.

Tried on latest dev and 3.5.0-rc1.

Contributor guide

Research direction
Investigate the NuGet.CommandLine or NuGet.Packaging code that generates the symbol package file name, focusing on the suffix application logic.
Tech stack
csharp
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNuGet CLI knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75