OpenHistoricalMap/issues

Date filter in iD should prefer EDTF dates over basic dates

Open

#671 opened on Jan 7, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees) (2 forks)auto 404
datesgood first issueiD

Repository metrics

Stars
 (31 stars)
PR merge metrics
 (PR metrics pending)

Description

Now that OpenHistoricalMap/iD#187 has added an EDTF date field and validator, the user might expect the date filter to filter features based on the EDTF dates when available. This would make it easier to edit in areas without many certain dates.

The edtf.js library we’re using can return the minimum and maximum possible dates of an EDTF date, optionally with the same precision as the input.

This filtering would be inconsistent with the renderer until we implement similar EDTF-based filtering in the tile generator: #15.

Contributor guide

Research direction
Investigate the edtf.js library to understand how to extract minimum and maximum possible dates from an EDTF date string. Then, modify the date filter logic in the iD editor to prioritize EDTF dates over basic dates when available, while ensuring consistency with the tile generator's future EDTF support.
Tech stack
javascript
Domain
frontendbackend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70