PHAREHUB/PHARE

isIn for boxcontainer is ambiguous

Open

#1,003 opened on Apr 29, 2025

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (33 forks)auto 404
coregood first issuerefactoring

Repository metrics

Stars
 (78 stars)
PR merge metrics
 (PR metrics pending)

Description

Since the addition of the box iterator, making a box iterable,

the following function may lead to some inconsistencies (which I'm seeing on a branch atm)

https://github.com/PHAREHUB/PHARE/blob/83a9afbfa2cda038c970280fb1ab61cd5760ceb1/src/core/utilities/box/box.hpp#L205-L233

suggested refactor, rename to isInAny

Contributor guide

Research direction
Inspect the `isIn` function in box.hpp and trace all its usages; rename to `isInAny` and update all references.
Tech stack
cpp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75