PHAREHUB/PHARE

macro ends in semi colon

Open

#1,094 opened on Oct 28, 2025

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (33 forks)auto 404
good first issuerefactoring

Repository metrics

Stars
 (78 stars)
PR merge metrics
 (PR metrics pending)

Description

this allows for users to not have a semi colon at the call site of this macro, which is somewhat inconsistent

https://github.com/PHAREHUB/PHARE/blob/238185fa1027a7915ca44d13fabddd7534620289/src/core/logger.hpp#L18

Contributor guide

Research direction
Remove the trailing semicolon from the macro definition in src/core/logger.hpp at line 18 to allow call sites without a semicolon.
Tech stack
cpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90