ParadiseSS13/Paradise

/obj/docking_port/mobile keeps a hard reference of the last_caller

Open

#19,295 opened on Oct 5, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)DM (1,313 forks)batch import
GC RelatedGood First Issue

Repository metrics

Stars
 (445 stars)
PR merge metrics
 (Avg merge 13d 5h) (90 merged PRs in 30d)

Description

Issue Description: The mobile docking ports keep a hard reference to the last caller. /datum/controller/subsystem/shuttle/proc/moveShuttle is the proc which sets it.

[2022-10-05T20:51:06] Found /mob/dead/observer [0x300003b] in /obj/docking_port/mobile's [0x200057f] last_caller var. World -> /obj/docking_port/mobile

Steps to reproduce the problem:

  1. Spawn as a ghost or aghost.
  2. Use any shuttle console and call/send the shuttle
  3. Become a mob or something else to delete the ghost

When did the problem start happening: For a while. I have introduced it 2 years ago in #13208 :(

Extra information: It should use a UID here instead. This should be a relatively easy first GC issue.

Contributor guide

Research direction
Replace the hard reference with a UID in the mobile docking port's last caller variable. The relevant code is in `/datum/controller/subsystem/shuttle/proc/moveShuttle`.
Tech stack
None
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85