People-Places-Solutions/floodmodeller-api

Investigate unit label updates in `DAT` class

Open

#152 opened on Jan 8, 2025

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (23 forks)auto 404
buggood first issue

Repository metrics

Stars
 (42 stars)
PR merge metrics
 (PR metrics pending)

Description

The _update_unit_names method in the DAT class needs a more thorough check for whether a unit is one in the ICs, when updating labels in the ICs. For instance, culvert inlet and river section may have the same label, but only the river section label should update in the ICs.

Contributor guide

Research direction
Examine the update unit names method in the DAT class to understand how unit labels are currently updated in the ICs. Identify why culvert inlet and river section with same label cause incorrect updates, and propose a fix to distinguish between unit types.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50