People-Places-Solutions/floodmodeller-api

Fix lines ignored by linters

Open

#87 opened on Oct 12, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (23 forks)auto 404
good first issuerefactor

Repository metrics

Stars
 (42 stars)
PR merge metrics
 (PR metrics pending)

Description

To include linters within GitHub actions ASAP so that future code must pass them, some difficult lines of code were annotated to be ignored by the linters. These should be fixed. They can be found by searching the following within the codebase:

  • # noqa: C901 would otherwise fail mccabe complexity
  • # noqa: N801 would otherwise fail pep8 naming
  • # type: ignore would otherwise fail mypy type checking
  • # pylint: disable would otherwise fail pylint linting

Contributor guide

Research direction
Search the repository for the specified annotations (# noqa: C901, # noqa: N801, # type: ignore, # pylint: disable) and fix the code to comply with the linters, then remove the annotations.
Tech stack
python
Domain
backend
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80