PointCloudLibrary/pcl

Replace pcl::visualization::createPlane and pcl::visualization::PCLVisualizer::addPlane overloads by default arguments

Open

#1,653 opened on Jul 18, 2016

View on GitHub
 (6 comments) (0 reactions) (0 assignees)C++ (4,506 forks)batch import
good first issuekind: todomodule: visualization

Repository metrics

Stars
 (9,023 stars)
PR merge metrics
 (Avg merge 8d 7h) (3 merged PRs in 30d)

Description

The code is pretty similar and can be probably reduced by simply making a change to its signature with default initializers.

bool addPlane (const pcl::ModelCoefficients &coefficients, 
               double x = 0,
               double y = 0,
               double z = 0,
               const std::string &id = "plane",
               int viewport = 0);

and

PCL_EXPORTS vtkSmartPointer<vtkDataSet> 
createPlane (const pcl::ModelCoefficients &coefficients, double x = 0, double y = 0, double z = 0);

pcl::visualization::PCLVisualizer::addPlane method:

pcl::visualization::createPlane method:

Contributor guide

Research direction
Analyze the two existing overloads for addPlane and createPlane, then combine them into a single function with default arguments. Update all callers to work with the new signature.
Tech stack
cpp
Domain
computer graphics
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65