PointCloudLibrary/pcl

Inconsistent handling of default seed in NormalGenerator & UniformGenerator

Open

#2,985 opened on Apr 9, 2019

View on GitHub
 (3 comments) (1 reaction) (0 assignees)C++ (4,506 forks)batch import
effort: lowgood first issuekind: todoneeds: feedback

Repository metrics

Stars
 (9,023 stars)
PR merge metrics
 (Avg merge 8d 7h) (3 merged PRs in 30d)

Description

As already discussed here default seed in random.h is not handled consistently.

https://github.com/PointCloudLibrary/pcl/blob/b4c785bf32b392b4570201e8fe9f97395bd98ba1/common/include/pcl/common/random.h#L163-L186

One constructor of NormalGenerator has as default seed -1 during the other one (via Parameters) has 1 as default seed.

Furthermore you get currently following warning:

common/include/pcl/common/impl/random.hpp:49:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   if(parameters_.seed != -1)

So we should discuss how to adjust code there.

Contributor guide

Research direction
Inspect the random.h and random.hpp files to understand the seed handling in NormalGenerator and UniformGenerator constructors. Fix the inconsistent default seeds and resolve the signed/unsigned comparison warning.
Tech stack
cpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65