PyCQA/flake8-bugbear

Enforce order of decorators combined with `@abstractmethod`

Open

#279 opened on Aug 26, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (116 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (1,116 stars)
PR merge metrics
 (Avg merge 4h 17m) (3 merged PRs in 30d)

Description

When combining @abstractmethod with @property or @staticmethod, the latter must come first. This might be a good addition to this plugin.

Contributor guide

Research direction
Investigate the existing flake8 bugbear source code to understand how visitor patterns work for decorator checks. Look at existing checks like B024 for abstract base class. Implement a new checker that inspects decorators on methods and raises a warning when @abstractmethod is not the outermost decorator.
Tech stack
python
Domain
toolingdeveloper experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60