RicoSuter/NSwag

[CodeGen] Route Param are case-sensitive

Open

#1,202 opened on Feb 20, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C# (1,189 forks)batch import
help wantedtype: discussiontype: enhancement

Repository metrics

Stars
 (6,291 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Route params are case-sensitive and fail to be used via code gen.

Example route:

        [HttpGet]
        [Route("foo/{barId}")]
        public async Task<IHttpActionResult> GetPricingRegionDetailAsync(int barid) {}

Example code gen output:

urlBuilder_.Append("foo/{barId}");
urlBuilder_.Replace("{barid}", System.Uri.EscapeDataString(ConvertToString(barid, System.Globalization.CultureInfo.InvariantCulture)));

The replace methid is case sensitive.

Related to #368

Contributor guide

Research direction
Look at the code generation logic for route replacement to make it case insensitive. Check the Replace method usage and consider using a case insensitive string comparison when replacing route parameters.
Tech stack
csharp
Domain
api
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65