RicoSuter/NSwag

When using inheritance api versions are not correctly versioned

Open

#1,288 opened on Apr 19, 2018

View on GitHub
 (16 comments) (0 reactions) (0 assignees)C# (1,189 forks)batch import
help wantedproject: NSwag.SwaggerGeneration.AspNetCoretype: enhancement

Repository metrics

Stars
 (6,291 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

In ASP.NET Core, if you have a base controller with operations, and an inherited controller, and you use versioning, the version is not correctly discovered.

Contributor guide

Research direction
Examine the NSwag source code to understand how API versions are resolved for inherited controllers. Look at the versioning logic and see if there is a missing check for base controller attributes.
Tech stack
csharp
Domain
backendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C#ASP.NET CoreNSwagAPI versioning
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55