RicoSuter/NSwag

Controller Code does not compile .NET Core 2.1 / ASP.NET Core 2.1.1

Open

#1,564 opened on Aug 29, 2018

View on GitHub
 (3 comments) (1 reaction) (0 assignees)C# (1,189 forks)batch import
help wantedproject: NSwag.CodeGeneration.CSharp (Controllers)type: enhancement

Repository metrics

Stars
 (6,291 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hello,

There is several issues in compiling Controller code for .NET Core 2.1 / ASP.NET Core 2.1.1 - I cannot compile the code. Is it my mistake?

  • Microsoft.AspNetCore.Mvc.RoutePrefix attribute does not exist
  • (Check "Generate optional parameters" + Check "Add cancellation token"): optional parameters cannot be specified like that before the mandatory cancellation token
  • (Check "Wrap success responses to allow full response access"): Request.CreateResponse (no overload takes 2 arguments)

Best wishes!

Contributor guide

Research direction
Investigate the three compilation errors mentioned: check if RoutePrefix attribute exists in .NET Core 2.1/ASP.NET Core 2.1.1, verify optional parameter ordering with cancellation token, and confirm Request.CreateResponse overloads. Look at NSwag source code to understand code generation and test with a small .NET Core 2.1 project.
Tech stack
csharp
Domain
backendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C#.NET CoreNSwag
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65