RicoSuter/NSwag

Handling Preflight Requests in Generated Controllers in AspNetCore 2.2

Open

#2,086 opened on Apr 4, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (1,189 forks)batch import
help wantedproject: NSwag.CodeGeneration.CSharp (Controllers)

Repository metrics

Stars
 (6,291 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I have a controller class in asp.net core that is generated with nswag studio. The attributes that are autogenerated route for an OPTIONS preflight call. Not sure if I'm doing something wrong in other configuration or if the generated code is incorrect.

[Microsoft.AspNetCore.Mvc.HttpPut, Microsoft.AspNetCore.Mvc.Route("api/resource/{id}")] public System.Threading.Tasks.Task<FileResponse> ApiGeneratedMethod(System.Guid id, [Microsoft.AspNetCore.Mvc.FromBody] Resource resource) { }

Contributor guide

Research direction
Investigate how NSwag generates controllers and ensure that OPTIONS requests are handled correctly. Check if the generated attributes need additional configuration for CORS.
Tech stack
csharp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ASP.NET CoreNSwag
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60