RicoSuter/aurelia-bs

Problems using the same dialog module ID for demo and NPM

Open

#6 opened on Nov 10, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (2 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (7 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I could not find a way to use a single module ID for referencing dialogs. Currently I have try two IDs so that the dialog can be found in the demo app (hosted in the package) and as NPM package which is a little bit ugly and also shows compile errors when starting the demo:

https://github.com/RSuter/aurelia-bs/blob/master/src/dialog-service.ts#L42-L43

Contributor guide

Research direction
Investigate the two module IDs used in dialog service.ts and find a way to use a single ID that works both in the demo and when installed as an npm package.
Tech stack
typescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Aurelianpm
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55