RocketChat/Rocket.Chat

Invitation links show registration step when registration link is disabled

Open

#18,717 opened on Aug 28, 2020

View on GitHub
 (8 comments) (0 reactions) (0 assignees)TypeScript (13,573 forks)batch import
area: ui/uxhacktoberfesttriagedtype: bug

Repository metrics

Stars
 (45,311 stars)
PR merge metrics
 (Avg merge 6d 1h) (230 merged PRs in 30d)

Description

Description:

Currently, the registration link is disabled and it's available only via OAuth provider.

Via the normal login page https://chat.example.com it's not showing as expected, but when I send an invitation link to someone it appears.

Steps to reproduce:

  1. Add an OAuth provider
  2. Disable all the other authentication/registration methods
  3. Send an invitation link to someone

Expected behavior:

To see the login via oauth provider only, like the main login page:

Actual behavior:

I'm seeing the login and a registration link right below:

Server Setup Information:

  • Version of Rocket.Chat Server: 3.5.4
  • Operating System: Ubuntu 20.04
  • Deployment Method: docker-compose
  • Number of Running Instances: 1
  • DB Replicaset Oplog: Enabled
  • NodeJS Version: v12.16.1
  • MongoDB Version: 4.0.20

Client Setup Information

  • Desktop App or Browser Version: Google Chrome | 84.0.4147.135 (Official Build) (64-bit)
  • Operating System: Mac OS 10.15.6

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.